-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preferred citation format #2738
Conversation
Label: META |
Is it possible to review these changes in rendered form? |
You should be able to by installing Jekyll and the running |
Bleh, that would require me to not only clone this repository, but also install Ruby. 😢 |
If you have commit access here I'll make screenshots |
😰 |
Meh, I'll see it when the merge goes through. If it breaks everything I'm rolling back though! That being said, this being a meta change rather than an EIP I would prefer to get input from other editors first. I don't do research citations so this change is fine with me mostly because I don't care. If all of the other editors feel the same then I'll merge it. |
Fastest way to get this through is probably to get it on the next EIP meeting agenda. Seems getting agreement on meta changes outside of that is hard. |
_layouts/eip.html
Outdated
"discussionUrl": "{{ page["discussions-to"] | uri_escape }}", | ||
{% endif %} | ||
"inLanguage": "en-US", | ||
"license": "https://creativecommons.org/publicdomain/zero/1.0/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it is the recommended one for EIPs, I think this should be a copy of the license section of each EIP. Is it possible to omit this field to facilitate a quick merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it is the recommended one for EIPs
Not just recommended, required. Currently, all EIPs MUST be CC0 (which is why I indicated in that other thread that merging a GPL EIP would require winning holy war to get EIP-1 changed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@axic please advise if this fixes the issue or if I should remove it for faster merge.
We can always merge then add stuff later, not a big deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it says "must be in public domain", so CC0 or any other statement of public domain is valid. However, that line was added to EIP-1 after a bunch of EIPs were merged lacking a license statement, see #2062.
I think conceptually this PR is doing two things, so would prefer to deal with it separately, especially as there might be more discussion points around the schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear this is what the current EIP-1 states:
Copyright Waiver - All EIPs must be in the public domain. See the bottom of this EIP for an example copyright waiver.
It does not say it must be CC0, so using CC0 in the license line in my opinion is not 100% correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point. Due to an underspecification on schema.org, I have found that linking to the other part of the page is legal. Maybe it shouldn't be. That's their fault.
Fixed in 0f70b6b
Is this agreeable?
_layouts/eip.html
Outdated
"@context": "http://schema.org", | ||
"@type": "Article", | ||
"author": "{% include authorlist.html authors=page.author %}", | ||
"name": "EIP-{{ page.eip | xml_escape }}: {{ page.title | xml_escape }}{% if page.status != "Final" %} [DRAFT]{% endif %}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is misleading because it would treat superseded EIPs as drafts too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Fixed at c99546e
_layouts/eip.html
Outdated
{% if page["discussions-to"] != undefined %} | ||
"discussionUrl": "{{ page["discussions-to"] | uri_escape }}", | ||
{% endif %} | ||
"inLanguage": "en-US", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be also mandated in EIP-1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That language be English?
I agree. But I'm hoping to get this PR merged this year so I avoided touching EIP-1. I hope this PR is mergeable as-is and then updates to EIP-1 can be considered separately and next.
_layouts/eip.html
Outdated
Article schema specification: | ||
https://schema.org/Article | ||
{% endcomment %} | ||
<script type="application/ld+json"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think actually this PR should be split into two PRs: the citation addendum above and this JSON schema. They serve two different purposes.
There was some discussion about the JSON schema arguing which is the best one, but I can't seem to find the discussion unfortunately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still haven't found the discussion, just that I had a local branch adding TechArticle
.
Also _includes/head.html
already contains a jsonld section so it would be in conflict with this one.
Can you just pull the jsonld part out to a different conversation? Or perhaps pull out the citation into a new one, given we discussed jsonld here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in the current header:
<script type="application/ld+json">
{
"@type": "WebSite",
"url": "{{site.url}}",
"name": "{{site.title}}",
"description": "{{site.description}}",
"@context": "https://schema.org"
}
</script>
This was my incomplete version:
<script type="application/ld+json">
{
"@context": "https://schema.org",
"@type": "TechArticle",
"url": "{{site.url}}",
"name": "{{page.title | jsonify}}",
"description": "{{site.description | jsonify}}",
"headline": "",
"articleBody": "",
"datePublished": "",
"author": {
"@type": "Person",
"name": ""
},
"publisher": {
"@type": "Organization",
"name": "Ethereum Improvement Proposals (EIPs)",
"logo": {
"@type": "imageObject",
"url": "http://example.com/images/logo.png"
}
},
"image": {
"@type": "imageObject",
"url": "http://example.com/images/image.png"
}
</script>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed JSON-LD at fc1ecca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't see any controversy left here. good to merge?
I still recommend bringing it up at the EIP meeting. I'm pretty reluctant to merge meta changes without broader discussion among the editors and that seems to be the best way to achieve that. |
_layouts/eip.html
Outdated
IEEE specification for reference formatting: | ||
https://ieee-dataport.org/sites/default/files/analysis/27/IEEE%20Citation%20Guidelines.pdf | ||
{% endcomment %} | ||
<p>{% include authorlist.html authors=page.author %}, "EIP-{{ page.eip | xml_escape }}: {{ page.title | xml_escape }}{% if page.status == "Draft" or page.status = "Last Call" %} [DRAFT]{% endif %}," <em>Ethereum Improvement Proposals</em>, no. {{ page.eip | xml_escape }}, {{ page.created | date: "%B %Y" }}. [Online serial]. Available: https://eips.ethereum.org/EIPS/eip-{{ page.eip | xml_escape }}.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI seems to be unhappy with this:
{% if page.status == "Draft" or page.status = "Last Call" %}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, corrected at 34d4dd6
EIPIP is not authoritative and does not have decision makers. Therefore it is ineffectual and that is why I left. This current matter affects nobody, it is merely a HTML coding update, I believe it can be accepted with input only by a single person with commit access rather than requiring votes, socializing or other consensus measures. I have stopped contributing any material changes here precisely because this repository has no project scope, no actual editors, and no delegation of authority. Therefore improvements are impossible to be accepted. In light of this, again, this PR is a mere coding update, a correction. |
The purpose of my desire to get it into the meeting isn't to get consensus, it is just to get it in front of the eyes of all of the editors since it seems many of them don't watch GitHub closely. If no one voices any concerns (e.g., everyone just shrugs) then I'll have no problem merging this. |
This looks good to me @fulldecent! |
Sounds like this got green lit in the EIPIP meeting, so going to merge. |
* Add preferred citation format * Add [DRAFT] * Fix DRAFT * Update license to a link inside the article * remove json-id * Update eip.html
* Add preferred citation format * Add [DRAFT] * Fix DRAFT * Update license to a link inside the article * remove json-id * Update eip.html
For anybody that took the time to publish an EIP, and then well-known authors are citing your work as "EIP-xxx. The Ethereum Editors. 2017.," this PR is for you!
This PR provides a recommended citation text for each EIP. It is based on the IEEE citation format.
Also, this includes full data for the semantic web for scrapers. (The original Web 3.0, ahem.)
And all conformances are documented to authoritative sources.
Enjoy!